String problem with c++ game

[Kreij]

Try something like this.

int number;

int main()
{
    game();
}

void game ()
{
    bool valid_input = false;
    while (!valid_input)
    {
        valid_input = GetInput();
    }

    ... /// continue with game code
}

bool GetInput()
{
    cin >> number;
    if (cin.Fail())
    {
        // show error because it's a string
        return false;
    }
    else
    {
        if (number is < 0 || number > 9)
        {
             // show error becuase it's out of range
             return false;
        }
    }
    return true;
}

[Kreij]

My C++ is a little rusty so please forgive any syntax problems.

[Aleksander]

Still i get errors
Don't get the bool programming, but i got your idea and it seems better than try
EDIT:LOL, so you made your errors by yourself ahahahaha anyway thanks
I will try ti fix the errors

[Kreij]

What errors and what other problems.
If you keep posting, I'll keep trying to help.

bool (or Boolean) is just a type of variable (true or false).
I'm probably mixing C# and C++ code together. lol

[Aleksander]

Errors:
a function-definition is not allowed here before '{' token|
expected '}' at end of input|
no return statement in function returning non-void|
||=== Build finished: 2 errors, 1 warnings ===|

I think you are mixing something.... maybe cheese with rice

There are only 2 most awful errors ever.... parenthesis
One like this }
And one like this {

<o><o>
..L..
______

Help me!

[ctrain]

Originally Posted by Aleksander Dishnica

What should i put in this row when i have numbers from 1 to 10 for example?

cin.ignore(numeric_limits<streamsize>max(), '\n');

You don't change anything, it was right in the first place.

Originally Posted by Aleksander Dishnica

The problem is:
If the user types in a wrong integer like 3980218408....
that throws an error and the game goes back
If the user types in a string or char, that makes the game
restart infinitely
See the throw i have programmed in the first post

Also, your prototype is wrong as i don't mean to exit the game
The player could be anywhere, but if he doesn't press an integer
he looses the game and has to restart!

I already answered it why it's restarting, clear the error and stream or parse everything as a string from the start.

Originally Posted by temp02

You really shouldn't call the game function again when some error occurs, you would be increasing the call stack for no valid/good reason, use Kreij's approach and loop the game function call on main.
Also add "cin.clear();" to the catch, like so:

catch(int x)
{
  cout << "\n You typed a wrong number! ERROR: " << x << endl;
  cin.clear(); // flush the input error buffer
}

cin.clear() doesn't clear the input stream, it will just try and clear the error state and the offending character is probably still there.

[Kreij]

LOL ... I told you my C++ was a little rusty. Hard to write code without seeing the all the classes and the way you have everything set up.

[Aleksander]

Still, i think there should be something to make it.
Like they do it in games. There must be something we
have not figured out yet. Or maybe programers don't
really want us to know....

I will let it like that for now, as i don't know what to do
What if the user enters 12k321j3.... ahahahaha

[razaron]

I don't know c++ so here's my Java solution. It should be easy to convert to c++.

import java.util.*;

class test{
	
	public static void main(String args[]){
		game();
	}
	
	public static void game(){
		Scanner input = new Scanner(System.in);
		
		String userInput = input.nextLine();  //gets input from the user as a string.
		int inputAsInteger;
		
		if(checkInput(userInput)==true)
			inputAsInteger = Integer.parseInt(userInput);  //if "checker" from the checkInput() method is true for "userInput" parse it as an integer.
		else
			game(); //if not then start from the beginning.
		
		//carry on with the game() methods code using the variable "inputAsInteger" as the users input.
	}
	
	public static boolean checkInput(String x){
		boolean checker = false;
		
		try{
			int i = Integer.parseInt(x);
			checker = true;	//if the string does parse, checker will equal true.
		}
		catch(Exception e){
			checker = false;	//if the string does NOT parse, checker will equal false.
		}
		
		return checker;
	}
}

EDIT: why are my tabs so big and everyone else's so small?
EDIT2: I forgot to initialize "inputAsInteger". Make it initially equal to 0 and then it should work.

[Aleksander]

After all.... you are not a beginner in java anymore
Btw you tabs are equal as all
I hate java, since the last version.
Anyway, why the hell you return checker?
What i got from your statement is:
Sorry man, i cannot speak english, this is why i am speaking american
If you don't know c++ how comes you programmed it in java?
Also, your program, if converted, the problem will persist for sure

[razaron]

You have to return checker so your method knows which boolean to return (even though there's only one).
Also the program works. It keeps initializing game() until a correct input is given. I checked it by adding "System.out.println(inputAsInteger);" at the end of the game() method.
As for why in Java. That's because I managed to help you and understand your c++ code without knowing c++. Java and c++ are amazingly similar.

EDIT: I'm still a noob.

[Kreij]

Originally Posted by razaron

EDIT: why are my tabs so big and everyone else's so small?

I use spaces for indents, not tabs in the code tags.

[ctrain]

Originally Posted by Aleksander Dishnica

Still, i think there should be something to make it.
Like they do it in games. There must be something we
have not figured out yet. Or maybe programers don't
really want us to know....

I will let it like that for now, as i don't know what to do
What if the user enters 12k321j3.... ahahahaha

I showed how to handle it...

[Kreij]

@Raz : Your Java code does a recursive call to game(). That is never something you want to do when error checking. Each time the game() method is called the calling method gets put on the stack as the recursive called method has to return to the calling method, so when the last game() call finaly completes it has to pop back through any game() method calls that called it.

Hope tht's not too confusing.

[Aleksander]

Originally Posted by ctrain

I showed how to handle it...

Lol didn't get much attention :P

[Aleksander]

Tried making a char or string value to the number instead of int, but still nothing new.
It works worse
I tried another kind of programming of the exceptions like this:

int number = 0;

try
{
     cin >> number;
     
     if(number < 1 || number >7)
     {
           throw 200;
     }
}
catch(int e)
{
       cout << "\n You typed a wrong number! ERROR: " << e << endl;
}
catch(ios_base::failure&)
{
       cout << "\n You didn't type in a number!!" << endl;
}
catch(...)
{
       cout << "\n I don't know what happened" << endl;
}

Still the problem wont be fixed

[ctrain]

save exceptions for... exceptional behavior, not something you can easily predict.


you can use stringstream for converting numerical types to strings and vice versa.

[Aleksander]

I don't have to convert the int to string.
If i convert it, the user had already input the number