Issue with updating via batch

[Solaris17]

As a proof of concept im attempting to update a batch file by having it check for a new "version" currently this is the code I have but set /p seems to not work.

Currently I use a text file with the version number in it. Ideally it should check this number and then decide if the current version is good or not. Unfortunately CMD gets stuck at setting the version and does not try to continue to bits. I heard of a way to use delims but im uncertain how this would work. This is what I have now.

set /p version=1.9.2

bitsadmin /transfer ATLAS /download /priority high http://www.teamdotexe.org/Downloads/version.txt "%userprofile%\desktop\version.txt"
set /p nwstvrsn=<version.txt
set nwstvrsn=%nwstvrsn: =%
if %version% lss %nwstvrsn% goto newupdateavailable
if %version%==%nwstvrsn% goto noupdateavailable

:newupdateavailable
echo Downloading Update
bitsadmin /transfer ATLAS /download /priority high http://www.teamdotexe.org/Downloads/"ATLAS %nwstvrsn%.bat" "%userprofile%\desktop\"

:noupdateavailable
echo No Update Available

 

[FordGT90Concept]

Are you intending to prompt the user for the version number? If not, you should be using /a and put it in quotes. If you haven't found it already this page should prove very helpful.

 

[Solaris17]

I still couldnt get it to do what i really wanted it to do so I have a manual invoke in place.

:vcheck
@echo off
cls
bitsadmin /transfer Version /download /priority high http://www.teamdotexe.org/Downloads/version.txt "%userprofile%\desktop\version.txt"
Echo.
Echo Checking version of ATLAS on the server.
Echo.
Echo Current version is...
Echo.
type "%userprofile%\desktop\version.txt"
Echo.
Echo.
Echo Version of ATLAS running is %build%
Echo.
DEL "%userprofile%\desktop\version.txt"
Echo Do you want to update?
Echo.
Echo 1 = YES
Echo.
Echo 2 = NO
ECHO.
set choice=
ECHO.
Echo Select (1) or (2)
Echo.
set /p choice=
if not '%choice%'=='' set choice=%choice:~0,1%
if '%choice%'=='1' goto update
if '%choice%'=='2' goto menu

:update
@Echo off
cls
Echo.
bitsadmin /transfer ATLAS /download /priority high http://www.teamdotexe.org/Downloads/ATLAS.bat "%userprofile%\desktop\ATLAS-%random%.bat"
Echo.
Echo Download Complete!
Echo.
Echo Re-Run ATLAS after this window closes!
Echo.
goto end

that is the finished product above for those interested.

%build% is a set variable I have at the beginning of the batch. that is manually updated with each change. version.txt is changed on the server with each iteration.

in this instance ATLAS deletes itself in :END after downloading the new version from the server and appending a random number to the save so that it is not deleted.

 

[OneMoar]

you need double quotes when using set /p
e.g
set/p "choice="
also remove the space between beween set and /p like the above

 

[OneMoar]

like so