- Joined
- Apr 16, 2009
- Messages
- 8,194 (1.49/day)
- Location
- Charleston, SC
System Name | Tower of Power / Sechs |
---|---|
Processor | i7 14700K / i7 5820k @ 4.5ghz |
Motherboard | ASUS ROG Strix Z690-A Gaming WiFi D4 / X99S GAMING 7 |
Cooling | CM MasterLiquid ML360 Mirror ARGB Close-Loop AIO / CORSAIR Hydro Series H100i Extreme |
Memory | CORSAIR Vengeance LPX 32GB (2 x 16GB) DDR4 3600 / G.Skill DDR4 2800 16GB 4x4GB |
Video Card(s) | ASUS TUF Gaming GeForce RTX 4070 Ti / ASUS TUF Gaming GeForce RTX 3070 V2 OC Edition |
Storage | 4x Samsung 980 Pro 1TB M.2, 2x Crucial 1TB SSD / Samsung 870 PRO 500GB M.2 |
Display(s) | Samsung 32" Odyssy G5 Gaming 144hz 1440p, ViewSonic 32" 72hz 1440p / 2x ViewSonic 32" 72hz 1440p |
Case | Phantek "400A" / Phanteks “Enthoo Pro series” |
Audio Device(s) | Realtek ALC4080 / Azalia Realtek ALC1150 |
Power Supply | Corsair RM Series RM750 / Corsair CXM CX600M |
Mouse | Glorious Gaming Model D Wireless / Razer DeathAdder Chroma |
Keyboard | Glorious GMMK with box-white switches / Keychron K6 pro with blue swithes |
VR HMD | Quest 3 (128gb) + Rift S + HTC Vive + DK1 |
Software | Windows 11 Pro x64 / Windows 10 Pro x64 |
Benchmark Scores | Yes |
It looks good Kreij! I see you have put a lot of time into this project. I'd like to make a small suggestion.. I would put a button above on the right side of the DataGrid to turn off/on allowupdate, allowDelete, and AllowAddNew. So, when someone is scrolling through there keys they don't accidently change something. I would add a messagebox or MsgBox to inform the user they enabled or disabled user changes inside the DataGrid as well.
Oh and I know you know this, but I'll say it for anyone here to learn. You can create a click event to the "Commit" button to enable those settings and disable once the new save data has been saved. You can also do more stuff like change the DataGrid OFF/On button text to red when it's off and green when it's on. This is just a good visual notification for the user.
EDIT: I said Save button.. I meant the Commit button..
Also, I noticed whenever you type directly into the DataGrid then change rows then back it crashes the app with an unhandled exception. See Below.
I would turn off the allowAddNew until the user clicked, "Commit" or wrap the code in a, "try... catch".
Oh and I know you know this, but I'll say it for anyone here to learn. You can create a click event to the "Commit" button to enable those settings and disable once the new save data has been saved. You can also do more stuff like change the DataGrid OFF/On button text to red when it's off and green when it's on. This is just a good visual notification for the user.
EDIT: I said Save button.. I meant the Commit button..
Also, I noticed whenever you type directly into the DataGrid then change rows then back it crashes the app with an unhandled exception. See Below.
Code:
************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at Key_Z.Form1.passwordsDataGridView_CellClick(Object sender, DataGridViewCellEventArgs e)
at System.Windows.Forms.DataGridView.OnCellClick(DataGridViewCellEventArgs e)
at System.Windows.Forms.DataGridView.OnMouseClick(MouseEventArgs e)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.DataGridView.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
I would turn off the allowAddNew until the user clicked, "Commit" or wrap the code in a, "try... catch".
Last edited: