• We've upgraded our forums. Please post any issues/requests in this thread.

Can I ask for reviews?

ClausS

New Member
Joined
Dec 7, 2016
Messages
3 (0.01/day)
Likes
1
#1
I am working on a currency converter, that I would really like to get some feedback on, however I don't want to break the rules, therefore I ask in advance before posting it.

Am I allowed to ask for adjustment advice on this forum?

Currently it is only available online, however I wish to make it into an app for people to use. The thought is, that the app should update once a day and thereby allowing the user to get the most of it even though it is offline.

I look forward to reading your response.
 

W1zzard

Administrator
Staff member
Joined
May 14, 2004
Messages
17,026 (3.43/day)
Likes
17,891
Processor Core i7-4790K
Memory 16 GB
Video Card(s) GTX 1080
Display(s) 30" 2560x1600 + 19" 1280x1024
Software Windows 7
#2
Sure, go ahead, as long as it's not a purely commercially motivated link you are posting.
 

ClausS

New Member
Joined
Dec 7, 2016
Messages
3 (0.01/day)
Likes
1
#3
Alright thanks! I really appreciate it! I am already working on adjusting the size to fit on an iPhone + and the white space between the numbers are being worked on as well. Here you can see the currency converter.
 
Last edited:
Joined
Aug 11, 2016
Messages
34 (0.07/day)
Likes
19
Location
NC
System Name Self Built
Processor AMD Processor FX-8350 Black Edition Vishera 8-Core 4.0GHz
Motherboard GIGABYTE GA-990FXA-UD3 AM3+
Cooling CORSAIR Hydro Series H60
Memory G.SKILL Ripjaws X Series 16GB
Video Card(s) EVGA GTX 970 and EVGA GTX650 Ti Boost
Storage 480 SSD 3x 3TB Sata
Display(s) ACER 23" Touch and 32" Toshiba
Case Self Built
Audio Device(s) On Board
Power Supply NZXT HALE82 HALE82-850-M 850W
Mouse Razer Naga Epic Chroma
Keyboard Logitech G510
Software Win 10
#4
I compared it to the one on Google search using the US to JPN. As I played around with it converting $52 US to JPN Yen. Google shows JPN equivalent as 5927.56 and yours shows 5929.76.

I even showed it to some of the guys in the office who travel over seas a lot and they liked it.
 
Joined
Dec 14, 2009
Messages
6,582 (2.25/day)
Likes
5,814
Location
Glasgow - home of formal profanity
System Name New Ho'Ryzen
Processor Ryzen 1700X @ 3.82Ghz
Motherboard Asus Crosshair VI Hero
Cooling TR Le Grand Macho & custom GPU loop
Memory 16Gb G.Skill 3200 RGB
Video Card(s) GTX1080ti (Heatkiller WB) @ 2Ghz core/1.5(12)Ghz mem
Storage Samsumg 960 Pro m2. 512Gb
Display(s) Dell Ultrasharp 27" (2560x1440)
Case Lian Li PC-V33WX
Audio Device(s) On Board
Power Supply Seasonic Prime TItanium 850
Software W10
Benchmark Scores Look, it's a Ryzen on air........ What's the point?
#5
Enormous list of currency maybe needs alphabetised? Also flags for currency towards end of list are not left margin adjusted, at least when I checked.
But looks good and straightforward.
 
Joined
May 27, 2008
Messages
3,577 (1.03/day)
Likes
533
Location
Huddersfield, uk
Processor E8200
Motherboard Asus P5KC
Cooling cooler master hyper tx3, 2x 120mm, 1x 80mm
Memory 4 GB DDR3 OCZ Black Edition
Video Card(s) Gigabyte HD 2600xt silent pipe II
Storage 500GB WD Sata / 60 GB Samsung IDE
Display(s) 20" samusng LCD, gaming at 1680 x 1050
Case some old amd thing
Audio Device(s) onboard
Power Supply 650W
Software Windows 8.1, with 'start is back' obviously
Benchmark Scores It boots whilst im still young so im pleased with that.
#6
Looks cool, there are some overflow issues when people enter stupidly large numbers however.

Adding overflow:auto to the classes top_results/bottom_results would alleviate it that or set min-height instead of just height so they can expand if needed. However then the element with id 'results-wrapper' would need the same treatment. Otherwise it wont expand when its child elements do.

Best to try to avoid designing layout with fixed heights/positions. Makes making things responsive more difficult, especially if you want to target multiple screen sizes.
 

damian246

New Member
Joined
Jan 10, 2017
Messages
18 (0.05/day)
Likes
3
#7
Sure, go ahead, as long as it's not a purely commercially motivated link you are posting.
Wouldn't mind if I could ask for the same privilege. I tried to open a new thread but I couldn't find it or its not possible.
 

Tatty_One

Super Moderator
Staff member
Joined
Jan 18, 2006
Messages
19,745 (4.54/day)
Likes
6,009
Location
Worcestershire, UK
Processor Skylake Core i7 6700k @ 4.6gig
Motherboard MSI Z170A Tomahawk
Cooling Cooler Master Seidon 240V AIO/Viper140's
Memory 16GB Corsair Vengeance LPX 3000mhz CL14
Video Card(s) Sapphire 4gb R9 290X VaporX @1150mhz
Storage SkHynix SL308 120GB/CrucialM4/1TB WD Black
Display(s) LG 29inch 2560x1080 Curved Ultrawide IPS
Case Phanteks Enthoo Pro M Windowed - Gunmetal
Audio Device(s) Xifi Elite Pro 7.1/VideoLogic ZXR550's
Power Supply XFX Pro Black Edition 750W Gold modular
Keyboard CM Storm Octane Combo
Software Win 10 Home x64
#8
I like the look of it, is it possible to add the conversion rate, some people may enquire with different exchanges/shops for rates locally and many just tell you the rate, is it possible to also show the rate?
 
Joined
Aug 11, 2016
Messages
34 (0.07/day)
Likes
19
Location
NC
System Name Self Built
Processor AMD Processor FX-8350 Black Edition Vishera 8-Core 4.0GHz
Motherboard GIGABYTE GA-990FXA-UD3 AM3+
Cooling CORSAIR Hydro Series H60
Memory G.SKILL Ripjaws X Series 16GB
Video Card(s) EVGA GTX 970 and EVGA GTX650 Ti Boost
Storage 480 SSD 3x 3TB Sata
Display(s) ACER 23" Touch and 32" Toshiba
Case Self Built
Audio Device(s) On Board
Power Supply NZXT HALE82 HALE82-850-M 850W
Mouse Razer Naga Epic Chroma
Keyboard Logitech G510
Software Win 10
#9
Still like the look, but did the us to jp currency converter and it still seems off. On your I did $525 USD and got 60599.26 Yen. Test through google currency converter and with $525 US I get 60562.95 Yen. Could this been something with the exchange rate changes?
 
Joined
Oct 17, 2012
Messages
6,821 (3.63/day)
Likes
8,962
Location
Massachusetts
Processor i7 4790
Motherboard Asrock Z97 Extreme 4
Cooling Corsair H-110i GTX
Memory 16 Gb kingston Hyper X
Video Card(s) Nvidia Reference GTX 970 x2
Storage C:\Samsung 850EVO 500Gb & Samsung 850 evo 250Gb
Display(s) Dell Ultra Sharp Widescreen 24" 1200P
Case Phanteks Enthoo Pro M Acrylic
Audio Device(s) Realtech Edition X1789,Ver2.78
Power Supply EVGA 220-G2-0650-Y1
Mouse Logitech G502 spectrum
Keyboard AZIO MRGB Kaith Blue
Software Win 10 Professional 64 bit
Benchmark Scores Congrats USA!! on the Travel Ban.....
#10
On my iPhone, seems to work well enough smooth scrolling, responsive. Flags are left right middle, don't know if that's intentional or not I'll include a screenshot

 

damian246

New Member
Joined
Jan 10, 2017
Messages
18 (0.05/day)
Likes
3
#11
Wouldn't mind if I could ask for the same privilege. I tried to open a new thread but I couldn't find it or its not possible.
I like the look of it, is it possible to add the conversion rate, some people may enquire with different exchanges/shops for rates locally and many just tell you the rate, is it possible to also show the rate?
I like the review idea but cannot open a separate thread, and I certainly would not like to highjack this one.
 
Joined
Mar 13, 2014
Messages
3,150 (2.30/day)
Likes
3,813
Processor i5-3570K
Motherboard ASUS P8Z77-V
Cooling CM Hyper 212 EVO
Memory 2 x 8 GB G.SKILL Ripjaws X
Video Card(s) MSI GTX 980 Ti GAMING
Storage Samsung 840 EVO 250 GB and WD Black 2TB
Display(s) ASUS 27 inch 1440p PLS PB278Q
Case Corsair Carbide 500R
Audio Device(s) Onboard
Power Supply Corsair HX750
Software Windows 7 Ultimate
#12
I like the review idea but cannot open a separate thread, and I certainly would not like to highjack this one.
If you want to start a thread here click on "Programming and Webmastering" and look to the upper right for the button "Post New Thread".

If you are wanting to start a new thread in the "Reviews" section I think that can only be done by TPU Staff.
 

damian246

New Member
Joined
Jan 10, 2017
Messages
18 (0.05/day)
Likes
3
#13
If you want to start a thread here click on "Programming and Webmastering" and look to the upper right for the button "Post New Thread".

If you are wanting to start a new thread in the "Reviews" section I think that can only be done by TPU Staff.
I wanted to open a new thread but I don't see any button of the "Post New Thread" kind.

Actually I just found one, thanks