String problem with c++ game

[GSquadron]

Hi guys!
I am having a little problem with my latest game in c++
i know how to give an error if the user types in a wrong number,
but i dont know how to make it if the user types in a string!
Anyone can help?
This is the code of the error so far:

try
    {
        if (number < 1 || number > 9)
        {
            throw 1;
        }
    }
    catch(int x)
    {
        cout << "\n You typed a wrong number! ERROR: " << x << endl;
        game();
    }

 

[GSquadron]

Tried this one:

try
    {
        if (number < z || number > a)
        {
            throw 1;
        }
    }
    catch(string x)
    {
        cout << "\n You typed a wrong number! ERROR: " << x << endl;
        game();
    }

 

[Kreij]

I think you can use something like this ...

if (static_cast<int>(number) == number)
{
    // it's an integer
}
else
{
    // it's not an integer
}

 

[GSquadron]

thanks
Where did you get that command btw?
It sounds very logic to me

 

[Kreij]

I'm not sure what you are asking.
static_cast<> is a C++ operator.

 

[GSquadron]

Never mind. Seems i can't find the real solution of the problem.
Yours does the same thing as the one i wrote
Anyway, nice programming trick
(i was asking where is the site where you learnt it)

The real problem is that if i type a char or string instead of a number, the game never ends restarting
I have this problem with all my games and this is the only thing i have not learned yet!
(i mean, fixing this problem, my games, will not have a single "bug")

 

[ctrain]

Never mind. Seems i can't find the real solution of the problem.
Yours does the same thing as the one i wrote
Anyway, nice programming trick
(i was asking where is the site where you learnt it)

The real problem is that if i type a char or string instead of a number, the game never ends restarting
I have this problem with all my games and this is the only thing i have not learned yet!
(i mean, fixing this problem, my games, will not have a single "bug")

cin is in the failure state and will just return immediately, you need to clear the fail state and wipe the input stream.

something like this:

int num;

std::cin >> num;
if(cin.fail())
{
	std::cout << "oh shit";
	
	std::cin.clear();							//clear the failure state
	std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n'); 	//clear the input stream
}

else
	...

 

[GSquadron]

What should i put in this row when i have numbers from 1 to 10 for example?

cin.ignore(numeric_limits<streamsize>max(), '\n');

 

[de.das.dude]

have you tried using the isdigit() function?
header is ctype.h

 

[GSquadron]

Same problem with the isdigit() lol
All things i have tried, all worked the same

 

[de.das.dude]

LOL something is borked i guess. things like this happen.

 

[Kreij]

Are you calling the game() method on a bad input?
That's what restarting the game, no?

If not, I'm confused.

Are you trying to do something like this?

While input does not equal the exit command
{
  Get input
  if (input is valid)
  {
      Do something with valid input and ask for next input
  }
  else
  {
      If (input does not equal the exit command)
      {
          Throw an error an error and ask for a valid input
      }
   }
}

 

[GSquadron]

The problem is:
If the user types in a wrong integer like 3980218408....
that throws an error and the game goes back
If the user types in a string or char, that makes the game
restart infinitely
See the throw i have programmed in the first post

Also, your prototype is wrong as i don't mean to exit the game
The player could be anywhere, but if he doesn't press an integer
he looses the game and has to restart!

 

[Kreij]

The pseudocode that I wrote would ask a player for input.
If the input was correct (valid) it would do something and then ask for the next input.
If the input was invalid, it would inform the player and then ask for input again.
If the player entered the "exit" string (whatever that may be) the game would quit.

Can you post your whole input code routine?

 

[GSquadron]

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <fstream>
#include <string>
#include <ctype.h>

using namespace std;

int main()
{
    game();
}

int game()
{
    cin >> number;

    try
    {
        if (number < 1 || number > 7)
        {
            throw 1;
        }
    }
    catch(int x)
    {
        cout << "\n You typed a wrong number! ERROR: " << x << endl;
        game();
    }

This is all needed, cuz the whole programming is 600 lines
I don't really think you will find anything with the code anyway.

 

[razaron]

Have you tried recursion*?

*Calling method x within method x.

 

[GSquadron]

You mean like this?

catch(int x)
    {
        cout << "\n You typed a wrong number! ERROR: " << x << endl;
        game();
    }

It is "recursioned", i just deleted like 70 lines of code in the post
If i put a string or char, the recursion continues infinitely (or a double || float)

 

[Kreij]

You don't want recursion in this case as you are just filling the stack and heap for no good reason. You should not call the game() method from within itself just for bad input.

 

[GSquadron]

If i don't put the recursion, the game ends!

 

[temp02]

You really shouldn't call the game function again when some error occurs, you would be increasing the call stack for no valid/good reason, use Kreij's approach and loop the game function call on main.
Also add "cin.clear();" to the catch, like so:

catch(int x)
{
  cout << "\n You typed a wrong number! ERROR: " << x << endl;
  cin.clear(); // flush the input error buffer
}

 

[razaron]

How about having x be a string (instead of an int) then try to parse it into an int? If it doesn't parse it should go to the catch.

EDIT: by x I mean the number you're inputting.

 

[Kreij]

If you "cin" to an integer, it will automatically go into a fail state (can't convert) as ctrain pointed out. You can use this to check to see if the inputted value is a string as opposed to an integer.

If the inputted integer is out of range, a simple range check will do.

 

[GSquadron]

LOL
tried razaron's suggestion it works but ends in an unusual way!
I created 2 try functions, one with int x and one with char x

 

[razaron]

Why and what 2 try functions?

 

[GSquadron]

try
    {
        if (number < 1 || number > 7)
        {
            throw 1;
        }
    }
    catch(int x)
    {
        cout << "\n You typed a wrong number! ERROR: " << x << endl;
        game();
    }
try
    {
        if (number < 1 || number > 7)
        {
            throw 2;
        }
    }
    catch(char x)
    {
        cout << "\n You typed a wrong number! ERROR: " << x << endl;
        game();
    }